Skip to content

test: ci/merge label with failing build — should still enter merge queue #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgwalters wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: ci/merge label with failing build — should still enter merge queue #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added ci/fail-build
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions test-results/heavy-fail.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This PR uses ci/merge label but has ci/fail-build. Key test: required-checks should still go green on the PR so it can enter the merge queue.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The directory 'test-results/' is conventionally used for ephemeral test output and reports, which are typically excluded from version control. Committing a persistent file here may be confusing or lead to accidental deletion by cleanup scripts. Consider moving this file to a directory intended for test sources or documentation, such as 'tests/' or 'ci/'. Additionally, the description could be more formal and use clearer terminology.

This PR uses the 'ci/merge' label and the 'ci/fail-build' file. The key test is to verify that 'required-checks' passes on the PR, allowing it to enter the merge queue.

Loading