Minor cleanups#46
Merged
Merged
Conversation
We should be able to rely on bink's auto-detection. See also https://github.com/alicefr/bink/pull/41.
This seems like an easy dedupe win in the future.
Should have a CI check for this.
Fail CI early if generated files or formatting are stale. This runs before unit tests since stale generated code makes test results meaningless. Assisted-by: Pi (Claude Opus 4.6)
Seems weird to have the e2e target live between 'unit' and 'lint'. It's more heavyweight than either of those things and requires extra setup. I think it still makes sense under the "Development" heading, but let's at least move it down.
Assisted-by: Pi (Claude Opus 4.6)
This somewhat reverts 3ab5283 ("ci: fetch versioned bink release instead of building from source") and solves the issue of a moving bink target by instead freezing on a specific commit. The original approach of downloading binaries makes sense. But I think it's a bit too early to move to that model. Let's wait until the testing needs of bootc-operator and bink itself are stabilized and then we can move to a binary release model. Assisted-by: Pi (Claude Opus 4.6)
alicefr
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages.