Fix JS error preventing people from starring talks at LPW2015#64
Open
mfontani wants to merge 1 commit intobook:masterfrom
Open
Fix JS error preventing people from starring talks at LPW2015#64mfontani wants to merge 1 commit intobook:masterfrom
mfontani wants to merge 1 commit intobook:masterfrom
Conversation
…ot using .prop() and no longer with .attr(), since jQuery 1.6+" The commit was right, _but_ act uses jQuery 1.3.2 which doesn't support prop() and therefore attr() is correct to be used. This reverts commit 0f91e32.
Author
|
Please see if this can be had a look at since it impacts LPW2015. i.e. go to http://act.yapc.eu/lpw2015/talks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit 0f91e32
Revert "apparently, one must check whether a checkbox is checked or not using .prop() and no longer with .attr(), since jQuery 1.6+"
The commit was right, but act uses jQuery 1.3.2 which doesn't support
prop() and therefore attr() is correct to be used.