Automate plugin metadata insertion#405
Automate plugin metadata insertion#405Loup-Garou911XD merged 1 commit intobombsquad-community:mainfrom
Conversation
|
this is more work on #387 but on a fork for easier testing |
|
omg i think it might be broken because its running the ci.yml from the upstream |
This comment was marked as outdated.
This comment was marked as outdated.
|
closing this because it will be causing alot of failing ci and flooding my inbox |
0354828 to
5e2cfc3
Compare
|
@bombsquad-community/plugman-maintainers have a view at this |
|
@pranav-1711 did you actually review it or just approved?? |
|
well lets test edge cases in prod |
|
I reviewed it briefly and approved it. Everything looks fine and nothing malicious. |
There was a problem hiding this comment.
Having some sort of unit test for this file could go a long way if someone feels like doing it.
There was a problem hiding this comment.
I didn't understand what you mean unit test for this file
There was a problem hiding this comment.
A CI workflow that tests the functions in this file. The test would just give some minimalistic parameters to the functions and check to see if what they return is what they are expected to return with those parameters and if the changes they make to files on the system are the exact changes that are expected with those parameters. This way if some change somewhere else were to bork this file you would be alerted before it becomes a bigger problem and you would know exactly what broke it right then and there.
To test:
P.S.: yes the second point does break it so ig ill implement 3rd point as a solution
ToDo: