Skip to content

Automate plugin metadata insertion#405

Merged
Loup-Garou911XD merged 1 commit intobombsquad-community:mainfrom
Loup-Garou911XD:main
Dec 10, 2025
Merged

Automate plugin metadata insertion#405
Loup-Garou911XD merged 1 commit intobombsquad-community:mainfrom
Loup-Garou911XD:main

Conversation

@Loup-Garou911XD
Copy link
Member

@Loup-Garou911XD Loup-Garou911XD commented Dec 8, 2025

To test:

  • adding new plugin
  • will Commit AutoPEP8 break the Apply Plugin Metadata if only 1 plugin gets formatted out of multiple ones
  • can i remove Commit AutoPEP8 and merge it with Apply Plugin Metadata to have just 1 Apply autopep8 and Plugin Metadata

P.S.: yes the second point does break it so ig ill implement 3rd point as a solution

ToDo:

  • update readme
  • how to modify plugin without update for when working on a pr
  • Think of other edge cases that can break this
  • test for plugman itself
  • support third party plugin sources
  • update readme for sample plugin source

@Loup-Garou911XD
Copy link
Member Author

Loup-Garou911XD commented Dec 8, 2025

this is more work on #387 but on a fork for easier testing

@Loup-Garou911XD
Copy link
Member Author

omg i think it might be broken because its running the ci.yml from the upstream
ig it should work after its merged

@Loup-Garou911XD

This comment was marked as outdated.

@Loup-Garou911XD
Copy link
Member Author

closing this because it will be causing alot of failing ci and flooding my inbox

@Loup-Garou911XD
Copy link
Member Author

@bombsquad-community/plugman-maintainers have a view at this

@Loup-Garou911XD
Copy link
Member Author

@pranav-1711 did you actually review it or just approved??
because i need another set of eyes to look at it in case i missed some edge case

@Loup-Garou911XD
Copy link
Member Author

well lets test edge cases in prod

@Loup-Garou911XD Loup-Garou911XD merged commit 80c6a67 into bombsquad-community:main Dec 10, 2025
1 check passed
@pranav-1711
Copy link
Collaborator

I reviewed it briefly and approved it. Everything looks fine and nothing malicious.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some sort of unit test for this file could go a long way if someone feels like doing it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand what you mean unit test for this file

Copy link

@EraOSBeta EraOSBeta Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A CI workflow that tests the functions in this file. The test would just give some minimalistic parameters to the functions and check to see if what they return is what they are expected to return with those parameters and if the changes they make to files on the system are the exact changes that are expected with those parameters. This way if some change somewhere else were to bork this file you would be alerted before it becomes a bigger problem and you would know exactly what broke it right then and there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants