Repository navigation
Conversation
When a required field had no sources at all (no CLI args, env vars, or defaults), the "none" source was not added to the sources array before constructing the ValidationError, resulting in an empty error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a required field has no input sources (no CLI args, env vars, or defaults), the error message is empty. For example, running
staticalizewith no arguments shows blank lines where the validation errors should be:Approach
The
ValidationErrorwas constructed with an emptysourcesarray because the "none" source (representing theundefinedfallback) was only pushed intosourceson the success path. Movedsources.push(source)to happen unconditionally so validation issues are always included in the error message. Added a minimal regression test.