Repository navigation
Add dry-run verification to publish workflow - #2
Merged
Merged
Conversation
Previously the publish workflow would build and publish to both npm and JSR in a single shot. If the JSR publish succeeded but the npm build was broken (or vice versa), we'd end up with a half-published release that's painful to recover from. Now verify-jsr and verify-npm run dry-run publishes first, and the real publish jobs only proceed once both pass. The npm build artifact is uploaded once and reused so the publish step doesn't rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The publish workflow builds and publishes to both npm and JSR in a single shot. If one registry publish succeeds but the other build is broken, we end up with a half-published release that's painful to recover from.
Approach
Add
verify-jsrandverify-npmgate jobs that perform dry-run publishes before the real thing. Bothpublish-npmandpublish-jsrnow depend on both verify jobs passing. The npm build artifact is uploaded once during verification and reused in the publish step to avoid rebuilding.