Skip to content

Re-enable multiple db table prefixes#2206

Draft
simongroenewolt wants to merge 4 commits intobolt:6.0from
simongroenewolt:feature/re-enable-multiple-table-prefixes
Draft

Re-enable multiple db table prefixes#2206
simongroenewolt wants to merge 4 commits intobolt:6.0from
simongroenewolt:feature/re-enable-multiple-table-prefixes

Conversation

@simongroenewolt
Copy link
Contributor

@simongroenewolt simongroenewolt commented Dec 2, 2020

Force initialization of ObjectManager for correct spl_object_hash() behavior.
Needed to get the correct spl_object_hash in case it is a proxy

Still needed: revert some changes that were done as workaround for the incorrect behavior of spl_object_hash()

@simongroenewolt
Copy link
Contributor Author

@bobdenotter I just realized that without talking about it this PR will just be forgotten :-)

Are you interested in getting this merged? I've still marked it WIP as the change itself doesn't do anything, it merely makes it possible to revert your old workaround that made it impossible to have multiple table prefixes. I'm a bit wary to include a revert of those changes in this PR, but maybe that would be the correct thing to do?

@bobdenotter
Copy link
Member

Are you interested in getting this merged?

Yes, certainly. What I've done there was undeniably a hack. If we can revert it, I'm all for it. :-)

@simongroenewolt simongroenewolt marked this pull request as ready for review May 11, 2021 18:25
@simongroenewolt simongroenewolt changed the title [WIP] Re-enable multiple db table prefixes Re-enable multiple db table prefixes May 11, 2021
@simongroenewolt
Copy link
Contributor Author

Now this PR actually re-enbles the use of different table prefixes -- I've reverted the workaround. As I didn't have time to actually test it I'll mark the PR 'work in progress' again.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

In an effort to keep our pull request list manageable, we are marking this PR as stale because it has been 60 days without activity. If this PR is still relevant, please let us know by posting a quick comment or update so that it can be assigned and hopefully merged.

@github-actions github-actions bot added the Stale label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants