ENH: add filter-reads-kraken2 action#340
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 94.60% 94.52% -0.09%
==========================================
Files 35 36 +1
Lines 2669 2848 +179
Branches 397 434 +37
==========================================
+ Hits 2525 2692 +167
- Misses 72 78 +6
- Partials 72 78 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I will review this on monday, if that is okay. I want to finish something today. |
VinzentRisch
reviewed
Jun 9, 2026
VinzentRisch
left a comment
Member
There was a problem hiding this comment.
Hey Michal
I ran the code with the data from the mock tutorial and with a couple of querys.
It all looks good but I have two comments below:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new action
filter-reads-kraken2that allows filtering a set of reads using their corresponding Kraken2 classifications.AI Disclosure
AI Usage Details
Codex was used during early stage implmentation. All the code was reviewed and tested before PR submission.