FIX: correctly set the DB param before the EFetch request#252
Merged
Conversation
Collaborator
|
Thank you for doing this @misialq! I was able to successfully run the command as outlined from this user's post. All tests also passed. I'll go ahead and merge. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
queryto fetch protein sequences we would make two requests: esearch + efetch. The DB for the first was set correctly, while for the second one it was hardcoded to "nuccore" (which is incorrect for fetching protein sequences). The code was updated to dynamically set the DB for the second request, depending on the DB used for the first request.Note: I'm not sure why this worked before but perhaps NCBI just started enforcing passing the correct DB in the linked EFetch request...