Complete Phase 4: Advanced Legislative Tracking with Critical Production Fixes

.githooks/README.md

@@ -0,0 +1,112 @@
+# Git Hooks for Ustawka
+
+This directory contains git hooks to maintain code quality and enforce development workflows.
+
+## Available Hooks
+
+### pre-commit
+- **Purpose**: Ensures code quality before commits
+- **Features**:
+  - Prevents direct commits to protected branches (`master`, `main`, `RELEASE`)
+  - Runs `make check` to verify linting and tests pass
+  - Provides helpful error messages and suggestions
+
+## Installation
+
+### Automatic Setup (Recommended)
+```bash
+# From project root
+./scripts/setup-hooks.sh
+```
+
+### Manual Setup
+```bash
+# Copy the hook to your local git hooks directory
+cp .githooks/pre-commit .git/hooks/pre-commit
+chmod +x .git/hooks/pre-commit
+```
+
+## Usage
+
+Once installed, the hooks run automatically:
+
+```bash
+# This will trigger the pre-commit hook
+git commit -m "your commit message"
+```
+
+### Protected Branches
+The pre-commit hook prevents direct commits to:
+- `master`
+- `main` 
+- `RELEASE`
+
+If you try to commit to these branches, you'll see:
+```
+❌ ERROR: Direct commits to 'master' branch are not allowed!
+💡 Please use a feature branch and create a pull request instead.
+```
+
+### Code Quality Checks
+The hook runs `make check` which includes:
+- Go linting (`golangci-lint`)
+- Unit tests
+- Code formatting verification
+
+If checks fail, you'll see detailed error messages and suggestions for fixes.
+
+## Recommended Workflow
+
+1. **Create a feature branch**:
+   ```bash
+   git checkout -b feat/your-feature-name
+   ```
+
+2. **Make your changes and commit**:
+   ```bash
+   git add .
+   git commit -m "feat: add your feature description"
+   ```
+
+3. **Push and create PR**:
+   ```bash
+   git push -u origin feat/your-feature-name
+   # Create pull request via GitHub/GitLab
+   ```
+
+## Bypassing Hooks (Emergency Only)
+
+In rare cases where you need to bypass the hook:
+```bash
+git commit --no-verify -m "emergency commit"
+```
+
+**⚠️ Warning**: Only use `--no-verify` in true emergencies. The hooks exist to maintain code quality.
+
+## Troubleshooting
+
+### Hook not running
+- Ensure the hook file is executable: `chmod +x .git/hooks/pre-commit`
+- Check that you're in the project root directory
+- Verify the hook file exists in `.git/hooks/pre-commit`
+
+### Make check failures
+- Run `make check` manually to see detailed errors
+- Common fixes:
+  - `go fmt ./...` for formatting issues
+  - `goimports -w .` for import organization
+  - Fix test failures shown in output
+
+### Missing dependencies
+- Ensure you have all required tools:
+  - `golangci-lint` for linting
+  - `gotestsum` for test execution (optional)
+  - Go toolchain properly installed
+
+## Contributing
+
+When adding new hooks:
+1. Add the hook file to `.githooks/`
+2. Update this README
+3. Update `scripts/setup-hooks.sh` if needed
+4. Test the hook thoroughly before committing

.githooks/pre-commit

@@ -0,0 +1,87 @@
+#!/bin/bash
+
+# Pre-commit hook for Ustawka project
+# 
+# This hook ensures code quality by:
+# 1. Preventing direct commits to protected branches (master, main, RELEASE)
+# 2. Running make check to verify linting and tests pass
+#
+# To install this hook for your local development:
+# cp .githooks/pre-commit .git/hooks/pre-commit
+# chmod +x .git/hooks/pre-commit
+
+set -e
+
+# Colors for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+BLUE='\033[0;34m'
+NC='\033[0m' # No Color
+
+# Get current branch name
+current_branch=$(git branch --show-current)
+
+echo -e "${BLUE}🔍 Ustawka Pre-commit Hook${NC}"
+echo -e "${YELLOW}Checking branch and code quality...${NC}"
+
+# 1. Check if we're trying to commit to protected branches
+protected_branches=("master" "main" "RELEASE")
+
+for protected in "${protected_branches[@]}"; do
+    if [[ "$current_branch" == "$protected" ]]; then
+        echo -e "${RED}❌ ERROR: Direct commits to '$protected' branch are not allowed!${NC}"
+        echo -e "${YELLOW}💡 Please use a feature branch and create a pull request instead.${NC}"
+        echo -e ""
+        echo -e "${YELLOW}   Create a feature branch:${NC}"
+        echo -e "   git checkout -b feature/your-feature-name"
+        echo -e "   git add ."
+        echo -e "   git commit -m 'your commit message'"
+        echo -e "   git push -u origin feature/your-feature-name"
+        echo -e ""
+        echo -e "${YELLOW}   Or use our git flow:${NC}"
+        echo -e "   git checkout -b feat/short-description"
+        echo -e "   # Make your changes, then:"
+        echo -e "   git add . && git commit -m 'feat: your feature description'"
+        echo -e "   git push -u origin feat/short-description"
+        exit 1
+    fi
+done
+
+echo -e "${GREEN}✓ Branch check passed: '$current_branch'${NC}"
+
+# 2. Ensure we're in the project root (where Makefile exists)
+if [[ ! -f "Makefile" ]]; then
+    echo -e "${RED}❌ ERROR: Makefile not found! Please run this from the project root.${NC}"
+    exit 1
+fi
+
+# 3. Run make check to ensure code quality
+echo -e "${YELLOW}🔍 Running make check (linting + unit tests)...${NC}"
+echo -e "${BLUE}This may take a moment...${NC}"
+
+if ! make check; then
+    echo -e ""
+    echo -e "${RED}❌ ERROR: make check failed!${NC}"
+    echo -e "${YELLOW}💡 Please fix the following before committing:${NC}"
+    echo -e "   • Linting issues (run 'make lint' for details)"
+    echo -e "   • Test failures (run 'make test-unit' for details)"
+    echo -e ""
+    echo -e "${YELLOW}   Quick fixes:${NC}"
+    echo -e "   • For formatting: Run 'go fmt ./...'"
+    echo -e "   • For imports: Run 'goimports -w .'"
+    echo -e "   • For linting: Check 'golangci-lint run'"
+    echo -e ""
+    echo -e "${BLUE}   Tip: You can run 'make check' manually to see all issues.${NC}"
+    exit 1
+fi
+
+echo -e ""
+echo -e "${GREEN}✓ make check passed!${NC}"
+echo -e "${GREEN}🎉 All pre-commit checks passed. Proceeding with commit...${NC}"
+
+# Optional: Show commit stats
+staged_files=$(git diff --cached --name-only | wc -l)
+echo -e "${BLUE}📁 Committing ${staged_files} file(s) on branch '${current_branch}'${NC}"
+
+exit 0

CLAUDE.md

@@ -71,4 +71,8 @@ Key environment variables:
 - Always run `make check` before commits (linting + unit tests required)
 - Service layer implements timeout management for external API calls
 - Metrics tracking available at `/metrics` endpoint
-- Database schema automatically handles migrations via triggers
+- Database schema automatically handles migrations via triggers
+
+## Git Practices
+
+- NEVER commit with "--no-verify"

Makefile

@@ -1,14 +1,18 @@
-.PHONY: check build run test test-unit test-e2e lint clean install-lint install-gotestsum
+.PHONY: check vet build run test test-unit test-e2e lint clean install-lint install-gotestsum
 
 # Binary name
 BINARY_NAME=ustawka
 GOTEST=gotestsum --junitfile unit-tests.xml --
 GOLANGCI_LINT_CMD := golangci-lint
 
 # Check: lint, and unit tests (no Docker)
-check: lint test-unit
+check: vet lint test-unit
 	@echo "Linters, and unit tests completed."
 
+vet:
+	@echo "Vet..."
+	@go vet ./...
+
 # Build the application
 build:
 	@echo "Building..."