Skip to content

ci: test downstream sbpf-linker against workspace crates - #135

Open
BretasArthur1 wants to merge 9 commits into
blueshift-gg:masterfrom
BretasArthur1:feat/downstream-ci
Open

BretasArthur1 wants to merge 9 commits into
blueshift-gg:masterfrom
BretasArthur1:feat/downstream-ci

Conversation

@BretasArthur1

@BretasArthur1 BretasArthur1 commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds a downstream workflow that builds and tests sbpf-linker at the sbpf-linker-next branch HEAD, against the sbpf crates in the checkout, so API breakage in the crates the linker consumes is caught in CI here, before a release is published.

How it works

  1. Checks out sbpf-linker in sbpf-linker-next branch HEAD next to this repo.
  2. Rewrites its sbpf-assembler/sbpf-common deps to use the checkout ones using cargo add --path.
  3. Verifies the patch took effect, the job fails if either crate still resolves to the registry, so the silent fallback can never produce a false green.
  4. Runs the linker's full test suite (compiletest + FileCheck over tests/assembly/*.rs), which exercises the assembler/common APIs e2e. Transitive workspace crates (sbpf-transform, sbpf-ir, sbpf-syscall-map) are verified along via the workspace's path deps.
  5. A new comment triggered workflow was introduced for testing users fork with the compatible version of sbpf-linker against the current checkout. Usage: /test-sbpf-linker <owner>/<repo> <ref>

@BretasArthur1
BretasArthur1 marked this pull request as ready for review August 20, 2026 12:51
@BretasArthur1
BretasArthur1 marked this pull request as draft August 20, 2026 18:37
@BretasArthur1

Copy link
Copy Markdown
Contributor Author

#159 broke compatibility with sbpf-linker when it moved opcode handling to tablegen. When sbpf releases a new version containing this new api, we should bump sbpf-linker deps and refactor the consumer in favor of the new api. This would fix it: blueshift-gg/sbpf-linker#50 and then we can have the downstream CI working.

@BretasArthur1
BretasArthur1 marked this pull request as ready for review September 6, 2026 00:36
Comment thread .github/workflows/downstream-sbpf-linker.yml Outdated
Comment thread .github/workflows/downstream-sbpf-linker.yml
Comment thread .github/workflows/downstream-sbpf-linker.yml Outdated
@codecov-commenter

codecov-commenter commented Sep 23, 2026 •

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants