h264/h265: log packet sizes if they exceed UDPMaxPayloadSize #4668
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatth
force-pushed
the
h2645-log-pkt-sizes
branch
2 times, most recently
from
b869265 to
01cf912
Compare
tmatth
commented
Jun 26, 2025
| p, err := New(1472, forma, false, | ||
| Logger(func(_ logger.Level, s string, i ...interface{}) { | ||
| require.Equal(t, "RTP packets are too big, remuxing them into smaller ones", fmt.Sprintf(s, i...)) | ||
| require.Equal(t, "RTP packets are too big (2012 > 1472), remuxing them into smaller ones", fmt.Sprintf(s, i...)) |
Contributor
Author
There was a problem hiding this comment.
I would've preferred not hardcoding the left-hand size value (2012) but it's not clear to me that the packet is in scope here.
tmatth
force-pushed
the
h2645-log-pkt-sizes
branch
2 times, most recently
from
73c03d6 to
ca12710
Compare
tmatth
force-pushed
the
h2645-log-pkt-sizes
branch
from
ca12710 to
5974195
Compare
tmatth
force-pushed
the
h2645-log-pkt-sizes
branch
from
5974195 to
8a71612
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
+ Coverage 55.57% 55.59% +0.01%
==========================================
Files 184 184
Lines 15504 15512 +8
==========================================
+ Hits 8617 8624 +7
- Misses 6157 6158 +1
Partials 730 730 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This would be helpful for debugging scenarios like #5161 |
Contributor
Author
|
ping @aler9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be helpful for knowing how to tune upstream sources to avoid the need for remuxing.