Major update - added strict types, added code quality tools#4
Open
indy2kro wants to merge 19 commits into
Open
Major update - added strict types, added code quality tools#4indy2kro wants to merge 19 commits into
indy2kro wants to merge 19 commits into
Conversation
added 11 commits
January 20, 2025 11:44
Owner
|
Hey @indy2kro , many thanks for your contribution. As already said in your other PR, it will take some time to be able to check all the changes you squeezed in this single PR. Again, I can just recommend providing smaller PRs, because that helps in getting code merged quickly and efficiently. |
Author
|
Well, this one is .. basically a re-write of the app. I understand your request, but the truth is there is so much changed it's easier to just consider a review from scratch or just to keep it as a separate fork. |
Owner
|
Keep in mind, that making small codebases "more professional" by introducing more tools and rules (like you would do in an enterprise project) sometimes adds a lot of overhead to simple pragmatic things. I will check it as soon as I find some time. |
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.5.3 to 11.5.6. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/11.5.6/ChangeLog-11.5.md) - [Commits](sebastianbergmann/phpunit@11.5.3...11.5.6) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.11.2 to 3.12.2. - [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases) - [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md) - [Commits](PHPCSStandards/PHP_CodeSniffer@3.11.2...3.12.2) --- updated-dependencies: - dependency-name: squizlabs/php_codesniffer dependency-version: 3.12.2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 2.1.1 to 2.1.12. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/2.1.x/CHANGELOG.md) - [Commits](phpstan/phpstan@2.1.1...2.1.12) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-version: 2.1.12 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tan-2.1.12 Bump phpstan/phpstan from 2.1.1 to 2.1.12
…p_codesniffer-3.12.2 Bump squizlabs/php_codesniffer from 3.11.2 to 3.12.2
…it-11.5.6 Bump phpunit/phpunit from 11.5.3 to 11.5.6
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.5.3 to 11.5.50. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/11.5.50/ChangeLog-11.5.md) - [Commits](sebastianbergmann/phpunit@11.5.3...11.5.50) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-version: 11.5.50 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…nit-11.5.50 Bump phpunit/phpunit from 11.5.3 to 11.5.50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major update, modernize tool, contains breaking changes from previous version.