Fix TUS complete: wrap parts in {"parts": [...]} - #3
Open
ghultink wants to merge 1 commit into
Open
Conversation
_tus_complete posted the parts list as a bare JSON array. The SAPI
/sapi/tus/{id}/complete endpoint expects a {"parts": [...]} object; given a
bare array it builds an empty CompleteMultipartUpload body, which S3 rejects
with MalformedXML (surfaced as HTTP 500). Every TUS upload (upload_file and
create_mediaclip) therefore failed at the complete step.
Wrap the payload in {"parts": parts}, matching the Blue Billywig Node CLI.
Verified live against a publication: uploads now complete with 200/success.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TusUploader._tus_completeposts the parts list as a bare JSON array:The SAPI
POST /sapi/tus/{id}/completeendpoint expects a{"parts": [...]}object. Given a bare array it builds an emptyCompleteMultipartUploadbody, which S3 rejects:This makes every TUS upload fail at the final step — both
upload_file()andcreate_mediaclip().Fix
Wrap the payload in
{"parts": parts}, matching the Blue Billywig Node CLI (bb-sapi.mjs, which sendsJSON.stringify({ parts })). Test updated accordingly.Verification
Verified live against a publication: the part PUTs to S3 already returned 200; with the wrapper the
completecall now returns200 {"success": true, ...}and the mediaclip transcodes normally. Confirmed by importing real clips end-to-end.