Repository navigation
Conversation
Preserve native file references and reject unsupported cross-format use. Refs #1080
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
3 tasks
bloodf
marked this pull request as ready for review
October 9, 2026 22:13
Owner
Author
|
V5 delivery tracking update Keep this PR active. Current head 33aa7f6 contains newer shared-converter and public POST file-ID fixes that are absent/different in #1297. Reconcile those residual changes into the canonical integration route before considering this source absorbed. Issue #1080 remains open until its full acceptance is verified. Evidence: current head |
5 tasks
(cherry picked from commit 42267fb63e70e5d7c49e571230347ff2beb88f29)
Preserve main's Cursor image pre-conversion validation and this PR's converter HTTP 400 contract for unresolved input_image.file_id values. Co-authored-by: Heitor Ramon Ribeiro <heitor.ramon@gmail.com>
chatCore now imports enforceCursorCapabilities; spreading the real capabilities module preserves that export without changing file-ID coverage. Co-authored-by: Heitor Ramon Ribeiro <heitor.ramon@gmail.com>
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current scope and review state — 2026-10-19
Reject scoped Responses image file IDs with HTTP 400 when translating to Chat Completions, while retaining URL precedence and native same-format Responses references. Cover message images and tool-output image arrays through registered conversion, the public POST boundary, and the secondary worker converter.
2d7fb0acc7515bed93fc16abdaa7eac8bbefe42e.e94884312ff6651f80d13f1c862e54a916bc870e(main).Repairs and reconciliation
Added worker error-result handling for intentional converter HTTP 400 failures. Follow-up RED/GREEN verification exposed and repaired scoped tool-output image IDs being serialized to text; paired image blocks are now validated before that serialization.
This head also retains the shared macOS fixture repair originating at
42267fb63e70e5d7c49e571230347ff2beb88f29: canonicalize the child fixture working directory so/varand/private/varaliases do not cause a false boundary failure. This is a test-fixture correction, not a relaxation of the production boundary.The previously identified newer #1256 residual is reconciled in #1297. This does not declare all #1089 protocol-conformance obligations complete, nor require merging both PRs merely to count delivery. Both remain open for maintainer disposition.
Verification and remaining gates
bdd243e3d7ed284ee94ce224a0d6e5c27bca2644passed 806 expanded offline assertions across 63 files, with zero failures and exact executed-file inventory. Root lint, docs, and pinned commitlint also passed that preceding candidate. These counts do not certify the newer head above.Current-head full checkpoint: PASS. Independently authenticated
2d7fb0acc7515bed93fc16abdaa7eac8bbefe42eagainst maine94884312ff6651f80d13f1c862e54a916bc870e: 1,424 eligible test files in four sequential batches; 12,565 passed, 0 failed, 65 reviewed conditional skips. Skipped assertions were not executed and are not counted as passes. Root lint, production build, repository consistency checks and pinned commit-range/title lint passed; website build/docs checks passed. Receipt SHA-256:4460e6aaca391f848b1172d80248765a9b542a197b57fd3da2c3d9743528319f. Runner SHA-256:459ecc7a85ce5d2ea2b3dd8fdccdbd971f7135c800944d36219c601cba499d9c. Source continuity: exact first-comment normalization independently verified; all remaining bundle bytes match HEAD. The external reviewed runner reused only hash-verified independent copies of matching locked dependency installations. This is offline gate evidence; live-provider, deployment and other platform acceptance remain limited to separately recorded tests.The GitHub ruleset requires zero approving reviews and requires resolved review threads. The repository’s independent local review contract still applies. Required exact-head
V5 Local CI, strict up-to-date integration, and thread resolution must be satisfied before a later maintainer merge; Vercel success alone is insufficient.Older statements below about draft publication, missing administrator/confinement proof, mandatory GitHub approving reviews, or unreconciled predecessor work are historical and are superseded by this current section. Older test counts and receipts apply only to their named heads.
Preserved prior PR description and historical evidence
The following is historical context; current scope and verification above supersede stale readiness, gate, dependency and environment claims. Earlier counts apply only to their named heads.
Scope
fix(translator): reject unresolved image file IDs (issue #1080). Draft publication of verified local implementation; base 93f6de6.
Closes #1080
Changed files
docs/reference/api.mdxopen-sse/translator/request/openai-responses.jstests/translator/bugs-codexCli-responses.test.jsLocal evidence
tests/.test-results.json: 12322 passed / 0 failed / 66 pending of 12388; success=TrueStatus
Draft. Not integrated; CI pending. Not merged or released. Publication gates (commitlint) not yet run by this publisher.
Review readiness update — 2026-10-09
Ready for review of the stated, finished PR scope; not ready to merge. This update supersedes earlier draft/parent-only publication wording without removing the original body or user notes.
067a951a689c5bc8c892040797dcc69ee4fce6f4; current main at audit:e51ab1c089800c2a70587822189997c482f53654.V5 Local CI: missing. No success status is published by this update.Retained implementation evidence supports review of the stated PR scope. Historical test counts and older successful checks do not establish integration with current main or a current full-CI pass. Prior local publication notes are historical; no gates were rerun by this delivery worker.
Current scope and review state — 2026-10-28
Reject scoped Responses image file IDs with HTTP 400 when translating to Chat Completions, while retaining URL precedence and native same-format Responses references. Cover message images and tool-output image arrays through registered conversion, the public POST boundary, and the secondary worker converter.
Closes #1080
Scope
open-sse/translator/formats/responsesApi.js—responsesImageUrlrejects scopedfile_idwithout URLopen-sse/translator/request/openai-responses.js— registered Responses→Chat lowering uses the same helperopen-sse/handlers/responsesHandler.js— converter HTTP 400 contract + main's Cursor pre-conversion image validationdocs/reference/api.mdxtests/unit/responses-file-id-*.test.js,tests/translator/bugs-codexCli-responses.test.jsIntegration (this update)
origin/main(5209b4aec3953106439231093c0c504af556959f) intov5/1080(no rebase / no force-push).open-sse/handlers/responsesHandler.jsonly. Resolution keeps both main'svalidateCursorImagespre-check and this PR's try/catch aroundconvertResponsesApiFormatfor HTTP 400.tests/unit/responses-file-id-chatcore.test.jsspreads the real module so main'senforceCursorCapabilitiesremains available.Exact SHAs
5209b4aec3953106439231093c0c504af556959f(origin/main)7a8fe94e80eb60e11c6f77f2b008906cfc3600d0Tests run (this head)
@commitlint/cli@18.6.1--from=origin/main --to=HEAD: PASS (0 problems; 1 historical footer warning)cd tests && node node_modules/vitest/vitest.mjs run translator/bugs-codexCli-responses.test.js unit/responses-file-id-chatcore.test.js unit/responses-file-id-handler.test.js unit/local-ci.test.js --maxWorkers=2→ 51/51 passedcd tests && npm run test:ci→ PASS — 13519 passed / 0 failed / 66 pending of 13585Docs / baseline
docs/reference/api.mdx(unchanged intent from PR)tests/__baseline__/known-fails.txtnot modifiedLocal-CI pre-check (authoritative runner from clean main; status NOT published)
origin/mainat5209b4ae…(/tmp/durindoor-local-ci-runner-main-1256)node scripts/local-ci.mjs --base 5209b4aec3953106439231093c0c504af556959f --head 7a8fe94e80eb60e11c6f77f2b008906cfc3600d0 --mode full --title "fix(translator): reject unresolved image file IDs" --repo <workspace> --out <0700 private root> --path-prepend /home/ubuntu/.nvm/versions/node/v20.20.2/bin7a8fe94e80eb60e11c6f77f2b008906cfc3600d0/home/ubuntu/.cache/durindoor-local-ci/pr1256-7a8fe94e80eb-20261028T202727Z/evidence.jsona5f20fb4e0569ea68030df64c1a48bf42556d11cbdafb27d7c709f0b16ae6547V5 Local CIand does not authorize merge by itself.Preserved prior PR description and historical evidence
The following is historical context; current scope and verification above supersede stale readiness, gate, dependency and environment claims. Earlier counts apply only to their named heads.
Scope
fix(translator): reject unresolved image file IDs (issue #1080). Draft publication of verified local implementation; base 93f6de6.
Closes #1080
Changed files
docs/reference/api.mdxopen-sse/translator/request/openai-responses.jstests/translator/bugs-codexCli-responses.test.jsLocal evidence
tests/.test-results.json: 12322 passed / 0 failed / 66 pending of 12388; success=TrueStatus
Draft. Not integrated; CI pending. Not merged or released. Publication gates (commitlint) not yet run by this publisher.
Review readiness update — 2026-10-09
Ready for review of the stated, finished PR scope; not ready to merge. This update supersedes earlier draft/parent-only publication wording without removing the original body or user notes.
067a951a689c5bc8c892040797dcc69ee4fce6f4; current main at audit:e51ab1c089800c2a70587822189997c482f53654.V5 Local CI: missing. No success status is published by this update.Retained implementation evidence supports review of the stated PR scope. Historical test counts and older successful checks do not establish integration with current main or a current full-CI pass. Prior local publication notes are historical; no gates were rerun by this delivery worker.