fix(buzz-acp): log author-gate rejections at INFO, not DEBUG - #5630
Open
Cynthia427 wants to merge 1 commit into
Open
fix(buzz-acp): log author-gate rejections at INFO, not DEBUG#5630Cynthia427 wants to merge 1 commit into
Cynthia427 wants to merge 1 commit into
Conversation
An author-gate rejection is invisible to the sender — their mention just sits there with no reaction — so the operator's log is the only place the refusal exists at all. At DEBUG level under default logging, a blocked mention is indistinguishable from a working one from both ends: seven days of journal on a production fleet contained zero gate lines while a user's mentions were being silently dropped, and the only diagnosis path was reasoning about absence. Bump both gate rejection sites (normal-mode inbound loop and setup-mode nudge gate) to INFO and include the event id, so one grep answers 'why did @agent ignore this message'. Signed-off-by: Cynthia Rohr <cynthia.r@kreativreason.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
author_allowedreturning false drops the inbound event with a DEBUG-level log line. Under default (INFO) logging that means a rejection produces no operator-visible signal at all — and the sender gets nothing back either, so a blocked mention fails identically to a working one from both ends.Measured on a production fleet: 7 days of
journalctlacross 8 agents contained zero gate lines while a user's mentions were being silently dropped. The only diagnosis path was reasoning about the absence of evidence.Change
Both gate rejection sites — the normal-mode inbound loop and the setup-mode nudge gate (
should_nudge_for_event) — now log at INFO with the event id included, so one grep answers "why did @agent ignore this message": author pubkey, channel, respond_to mode, is_dm, event id.A refusal that produces no signal is indistinguishable from success; this keeps the gate's behavior identical while making it observable.
Testing
cargo check -p buzz-acp,cargo fmt --checkclean; full pre-push suite (rust-tests, desktop, mobile) green.🤖 Generated with Claude Code