fix(desktop): more compact "compact" link previews - #5629
Open
tellaho wants to merge 2 commits into
Open
Conversation
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tellaho
marked this pull request as ready for review
August 12, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: improvement
User Impact: Compact link previews now use a single-line title and smaller thumbnail, making conversations easier to scan.
Problem: Compact previews gave long titles and oversized thumbnails too much visual weight in the message timeline.
Solution: Keep titles to one ellipsized line and reduce image thumbnails to a 104×64 treatment while preserving the existing wide aspect ratio; Rich previews remain unchanged.
File changes
desktop/src/shared/ui/compact-link-preview-attachment.tsx
Tightens the Compact presentation with a single-line title and smaller wide thumbnail, leaving Rich previews untouched.
desktop/tests/e2e/messaging.spec.ts
Adds focused coverage for title overflow, exact 64px card and 104×64 thumbnail geometry, and successful decoded-image rendering using a realistic fixture, plus an optional visual capture.
desktop/tests/fixtures/github-pr-5629-og.png
Provides realistic visible image bytes for the compact-preview image-rendering E2E path.
Reproduction steps
Screenshot