fix(buzz-acp): treat hermes-acp as a zero-arg agent - #5582
Open
mikeholownych wants to merge 1 commit into
Open
Conversation
default_agent_args() already special-cased other ACP adapters that take
no CLI args (codex-acp, claude-agent-acp, buzz-agent) but missed hermes,
despite default_agent_env() a few lines above already special-casing
hermes by name. Without this, the harness's clap default ("acp") gets
passed straight through to hermes-acp, which doesn't expect a positional
argument.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Mike Holownych <mike.holownych@aisyndicate.io>
|
Field-tested this against a real stock Hermes installation and an authorized private Buzz channel. Evidence:
I temporarily stopped the supervised Hermes gateway to avoid a duplicate consumer during the test and restored it afterward. This validates the narrow compatibility claim: the bundled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan