Skip to content

Conversation

@dalton-turner
Copy link
Collaborator

@dalton-turner dalton-turner commented Dec 17, 2025

Overview

Added support for skill-specific gitignore patterns to prevent generated skill files from being committed.

  • Extended the collect_all_gitignore_patterns function to include patterns from skill generators
  • Added logic to collect gitignore patterns from all tools that have skills generators
  • Added a new test case test_gitignore_includes_skill_patterns to verify that skill patterns are properly included for Claude, Codex, and AMP agents

Skills generators can create temporary files that should not be committed to version control. This change ensures that these generated skill files are automatically added to the gitignore patterns, maintaining a clean repository and preventing unnecessary files from being tracked.

This should be one of the final changes required to resolve #46

  • Test Binary

@dalton-turner dalton-turner marked this pull request as ready for review December 17, 2025 16:15
@jonandersen
Copy link
Collaborator

jonandersen commented Dec 17, 2025

  • add a PR to update README.md (add notes how the skills needs to be structured)

@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from 74558f5 to b9254eb Compare December 17, 2025 18:32
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch 2 times, most recently from 89bd961 to 398ea93 Compare December 17, 2025 18:54
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from b9254eb to 0a33d9b Compare December 17, 2025 18:54
@dalton-turner
Copy link
Collaborator Author

  • add a PR to update README.md (add notes how the skills needs to be structured)

#57

@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch from 398ea93 to aab9ef3 Compare December 17, 2025 19:16
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from 0a33d9b to 1a9db92 Compare December 17, 2025 19:16
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch from aab9ef3 to e5d95e2 Compare December 17, 2025 19:24
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from 1a9db92 to 0a6cf14 Compare December 17, 2025 19:24
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch from e5d95e2 to af96dfe Compare December 17, 2025 19:28
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from 0a6cf14 to bcbb39e Compare December 17, 2025 19:28
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch from af96dfe to cdbf3f3 Compare December 17, 2025 19:59
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from bcbb39e to ea82634 Compare December 17, 2025 19:59
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch from cdbf3f3 to b15a814 Compare December 17, 2025 20:39
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch 2 times, most recently from 24af3fe to 8a93a00 Compare December 17, 2025 20:47
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch from b15a814 to a995072 Compare December 17, 2025 20:47
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-status-command branch 2 times, most recently from 5430fae to 2868749 Compare December 17, 2025 20:53
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from 8a93a00 to cee6878 Compare December 17, 2025 20:53
@dalton-turner dalton-turner changed the base branch from dalton/integrate-skills-into-status-command to graphite-base/55 December 17, 2025 20:59
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from cee6878 to f89ced1 Compare December 17, 2025 21:00
@graphite-app graphite-app bot changed the base branch from graphite-base/55 to main December 17, 2025 21:00
@dalton-turner dalton-turner force-pushed the dalton/integrate-skills-into-gitignore-patterns branch from f89ced1 to b137441 Compare December 17, 2025 21:00
@dalton-turner dalton-turner merged commit 5005c2f into main Dec 17, 2025
7 checks passed
Copy link
Collaborator Author

Merge activity

@dalton-turner dalton-turner deleted the dalton/integrate-skills-into-gitignore-patterns branch December 17, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add skills generation for all supported agents

3 participants