Harden Python sandbox transient retries#154
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
The retry logic is correct — is_transient_reset_error properly gates retries on transport-level errors only, the _has_http_response_status guard prevents retrying real HTTP error responses, and closures correctly re-create BytesIO objects on each retry so multipart uploads don't replay an exhausted stream. CI failures (JSONDecodeError on HTML 403 in create_sandbox.py and missing sandbox-openai model) are environment-level issues in code untouched by this PR — safe to re-run.
Tag @mendral-app with feedback or questions. View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Note
Adds a shared
transient_retrymodule with exponential-backoff retry logic for transport-level failures (connection resets, GOAWAY, timeouts). Wraps all idempotent sandbox read/list operations and upload PUT paths in both the async and sync clients. Non-idempotent operations (process start/stop/kill) are intentionally left single-attempt. Adds two new settings (BL_FS_PART_RETRIES,BL_SANDBOX_READ_RETRIES) to configure retry budgets per-operation class.Written by Mendral for commit af560da.