Add support for Meson introspect#1648
Add support for Meson introspect#1648jmgeertsma wants to merge 2 commits intoblackducksoftware:masterfrom
Conversation
shantyk
requested review from
bd-samratmuk,
devmehtabd,
dterrybd,
fzhengbd,
sig-abyreddy and
zahidblackduck
Added 2 unit tests for MesonDetectable, 1 functional test MesonDependencyFileParser Mockito the meson.build and introspect files Update dita name to match the detector name Use BufferedReader for the JSON files Use Generic as forge
|
@jmgeertsma thanks very much for the contribution. We'd be very interested in discussing it further. Would it be possible for you to open a support ticket at https://community.blackduck.com/s/my-support-home so we can determine next steps. |
|
I opened case 03686036 |
|
The case got closed and D-I-171 got opened ... I have no idea where to find that thing, so I don't know if any progress is being made on Meson support. I created the pull request with functioning support. I provided test cases. Meson detect works if the project was build and it doesn't break any other scanners. Meson is a build system which compiles source code into a build directory. meson setup builddir meson compile -C builddir What else would I need to do to get this merged? My company depends on Meson and without support, Blackduck is useless to us. |
| <entry>Generic</entry> | ||
| <entry> | ||
| <p>File: meson.build</p> | ||
| <p>File: */meson-info/intro-project.json</p> |
There was a problem hiding this comment.
should the filename be "intro-projectinfo.json" ?
There was a problem hiding this comment.
The files is generated by Meson when running "meson setup builddir". The build directory can arbitrarily chosen, but the meson-info subdirectory and the intro-projectinfo.json and intro-dependencies.json files are fixed.
More information is available here
https://github.com/mesonbuild/meson/blob/master/docs/markdown/IDE-integration.md
| return requirements.result(); | ||
| } | ||
| logger.debug("even though {} is found, also a builddirectory with the introspect files is needed", detectable_file); | ||
| return new FilesNotFoundDetectableResult(); |
There was a problem hiding this comment.
Prefer to include the missing file names or paths
There was a problem hiding this comment.
The scan requires the file meson.build in the root of the project, but also the files */meson-info/intro-project.json and */meson-info/intro-dependencies.json. The * can be builddir or any name chosen in the setup.
3 participants
Description
Meson is a build system which compiles source code into a build directory. It creates a meson-info/intro-dependencies.json in the build directory which contains all the dependencies. This pull request will make detect look for the meson-info directory.