Repository navigation
fix(cockpit, briefing): one row per point, Jev in the bucket words, tabs answer only where they ask - #705
Open
mboiman wants to merge 4 commits into
Open
fix(cockpit, briefing): one row per point, Jev in the bucket words, tabs answer only where they ask#705mboiman wants to merge 4 commits into
mboiman wants to merge 4 commits into
Conversation
The advice made one collision finding per overlapping calendar event, and the view one row per finding, each numbered by the item's task: after bks-lab#704 one inbox item stood three times in Do with the same number. Now advise.py makes one finding per item naming every event, and briefing_view puts the collisions as reasons on the item's own row, or shows the item once (as itself, so its answers act on the item, not its task) where its section is out of the buckets. Findings of the older shape fold into the same row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: mboiman <mboiman@gmail.com>
Jev's squares say the profile's bucket words (Do, Plan, I'll do) and the light, not urgent square says Later, the answer that takes such a point out of sight, since no bucket holds it; the legend says you and the Bridge. A tab's own answers replace Do it only where it asks (tabAsksYou: a dialog, a ready answer, yes or no, a question in words). With the buckets on no tab offers Keep going; one that asks nothing offers Go to tab first and Later, Done, Obsolete on its item; a finished tab is no point (no Do chip) and offers only Go to tab and its close. Demo copy rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: mboiman <mboiman@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: mboiman <mboiman@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: mboiman <mboiman@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #704: three defects seen on a real cockpit right after it, each fixed test first.
1. One point, one row
An inbox item due at a time that overlapped three calendar events stood three times in Do (Dran and Work through), each numbered as its task, each saying "collides with the calendar". The advice made one collision finding per event, the view one row per finding.
skills/briefing/scripts/advise.py: one collision finding per inbox item, naming every event it collides with (inbox,item,eventson the finding).scripts/briefing.py:advise_rowspasses them on.scripts/lib/briefing_view.py: a collision is a reason on the item's own row (it then stands in Do); where the item has no row (its section is out of the buckets,bucket: none) it stands once as the inbox item itself, so its answers act on the item, never on its task. Findings of the older shape (one per event) fold into the same row.2. Jev in the bucket words
With the buckets on, Jev's squares say the profile's bucket words: urgent and weighty Do, weighty without hurry Plan, urgent and light I'll do. Light and not urgent has no bucket; that square says Later, the answer that takes such a point out of sight. That reads clearer than an empty square, which looks like a missing label, and it adds no fifth vocabulary. The legend says you and Bridge. Off, Jev keeps its own words.
3. A tab answers only where it asks
tabAsksYou: a dialog, a ready answer, yes or no, or a question in words. Only then do a tab's own answers replace Do it. With the buckets on:A scan of Start, Work (Due, By source, By Jev, Work through), the task board, Files and Chat in the mock with buckets on found no other answer word outside the four, a tab's own answers and the More items.
Tests
scripts/tests/test_briefing_collision_once.py,scripts/tests/bridge_cockpit_704_followup.test.mjs; the tests that held Jev's own words and "Keep going" in bucket mode now hold the new decision. Docs:docs/bridge-cockpit.md,docs/briefings.md. Demo copy rebuilt.check-all --full: 85 green, 0 red, 0 skipped.🤖 Generated with Claude Code