Skip to content

mail-draft: plain theme headings and quotes follow dark mode - #698

Merged
mboiman merged 1 commit into
bks-lab:mainfrom
mboiman:fix/mail-draft-plain-dark-mode
Nov 19, 2026
Merged

mboiman merged 1 commit into
bks-lab:mainfrom
mboiman:fix/mail-draft-plain-dark-mode

Conversation

@mboiman

@mboiman mboiman commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

What

The plain theme rendered headings (h1 to h3) and blockquotes with an inline text colour but without a class the dark-mode rules restyle. In a client in dark mode the background switches to #111418 and those headings stay #222222, which makes them unreadable.

Change

  • Plain headings get class="e-h", plain quotes get class="e-p e-rule".
  • New test DarkModeCoverage: for every built-in theme, every element that pins a colour inline must carry a class the dark rules restyle. It fails on main for the plain theme and passes with this change.

Verification

  • skills/mail-draft/run-tests.sh: 246 tests OK (3 skipped).
  • A plain-theme draft rendered with headless Chrome in forced dark mode: headings unreadable before, readable after.

🤖 Generated with Claude Code

The plain theme rendered headings and quotes with an inline text colour
but no class the dark-mode rules restyle. In dark mode the background
turned dark and the headings stayed #222222, unreadable. Both now carry
the dark classes; a test checks that every element pinning a colour in
every built-in theme has one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: mboiman <mboiman@gmail.com>
@mboiman
mboiman merged commit d1ef7af into bks-lab:main Nov 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant