Repository navigation
mail-draft: plain theme headings and quotes follow dark mode - #698
Merged
Merged
Conversation
The plain theme rendered headings and quotes with an inline text colour but no class the dark-mode rules restyle. In dark mode the background turned dark and the headings stayed #222222, unreadable. Both now carry the dark classes; a test checks that every element pinning a colour in every built-in theme has one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: mboiman <mboiman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
plaintheme rendered headings (h1toh3) and blockquotes with an inline text colour but without a class the dark-mode rules restyle. In a client in dark mode the background switches to#111418and those headings stay#222222, which makes them unreadable.Change
class="e-h", plain quotes getclass="e-p e-rule".DarkModeCoverage: for every built-in theme, every element that pins a colour inline must carry a class the dark rules restyle. It fails onmainfor theplaintheme and passes with this change.Verification
skills/mail-draft/run-tests.sh: 246 tests OK (3 skipped).🤖 Generated with Claude Code