Skip to content

feat(overlay): the scheduled sync can accept skill folders, and --accept says [y] by name - #696

Merged
mboiman merged 2 commits into
bks-lab:mainfrom
avondiel-dev:feat/overlay-unattended-accept
Nov 18, 2026
Merged

mboiman merged 2 commits into
bks-lab:mainfrom
avondiel-dev:feat/overlay-unattended-accept

Conversation

@avondiel-dev

Copy link
Copy Markdown
Contributor

Why

The daily overlay job (sync --unattended) withholds every skill folder that has one new file in it, and no person is there to say [y]. An overlay that ships a new reference or test with most skill changes falls behind although the job runs every morning. Measured on one instance: seven skill folders, 59 files pending, five of them skills that had been accepted long ago.

An agent session has the same problem from the other side: without a tty the prompt meets end of input, which counts as no.

What

Two commits, the second builds on the first.

1. --accept UNIT... (sync, apply, add). The same [y], given by name, for a place where no prompt can be answered. It writes the named units whole and leaves every other gated unit withheld. --yes never implies it. A name no gate asked about fails the run (exit 1). --unattended refuses the option (exit 2).

2. materialize.unattended_accept in the subscription. The consumer's standing answer for the scheduled run, per overlay:

Value The scheduled run accepts
none (default) nothing, as today
known a skill folder the consumer already holds a file of
all every behavioural unit, a new skill or sub-agent included

What stays as it is:

  • The default. Without the key nothing changes.
  • A folder that would overwrite a file of the consumer's own, or delete one, is never accepted unattended; it waits whole.
  • CORE-refusal and the leak gate run on every accepted file.
  • A conflict or a deletion outside a waiting folder still holds the overlay.
  • --yes and an interactive sync do not read the setting.

The summary line names what was accepted (accepted: skills/<name>/), status shows the setting, and an unknown value reads as none.

Open for review

Hard gate 3 of the overlay skill called the behavioural [y] non-negotiable. This PR makes it negotiable by an explicit, per-overlay opt-in of the consumer, never by the publisher and never by default. If all goes too far for CORE, known alone already fixes the measured case of accepted skills falling behind.

Tests

bash scripts/tests/test-overlay.sh: 430 passed, 0 failed (new sections 30 and 31). python3 scripts/check-all.py: 27 green.

🤖 Generated with Claude Code

avondiel-dev and others added 2 commits November 18, 2026 08:21
…n be answered

The behavioural gate needs a person's [y] per skill folder, and --yes
deliberately does not cover it. In an agent session or a shell without a
tty the prompt meets end of input, which counts as no, so a new skill
folder stayed withheld however often sync ran.

sync, apply and add take --accept UNIT...: the same [y], given by name.
It writes the named units whole and leaves every other gated unit
withheld. --yes never implies it. A name no gate asked about fails the
run (exit 1), and --unattended refuses the option (exit 2).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Axel von Dielingen <avd@reinvent-it.de>
…folders

The scheduled run withholds every skill folder that has one new file in
it, and nobody is there to say [y]. An overlay that ships a new reference
or test with most skill changes then falls behind although the job runs
every morning: seven skill folders, 59 files, on the instance this comes
from.

materialize.unattended_accept in the subscription is the consumer's
standing answer, per overlay, default none:
  known  a skill folder the consumer already holds a file of
  all    every behavioural unit, a new skill or sub-agent included

It never covers a folder that would overwrite a file of the consumer's
own or delete one; that folder waits whole, as before. CORE-refusal and
the leak gate run on every accepted file. Only --unattended reads it;
--yes and an interactive sync are unchanged. The summary line names what
was accepted, status shows the setting, an unknown value reads as none.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Axel von Dielingen <avd@reinvent-it.de>
@mboiman
mboiman merged commit 0572e51 into bks-lab:main Nov 18, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants