This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Use bitcore-lib as a peerDependency#639
Closed
CaptEmulation wants to merge 4 commits intobitpay:masterfrom
Closed
Conversation
This was referenced Mar 25, 2017
Contributor
|
I think this is not longer needed in current npm. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One wrinkle to using the bitcore stack is the obvious need to have a singleton
bitcore-lib. Thebitcoin-libpackage hosts thebitcoindlibrary and there are good reasons to not wanting to have multiplebitcoindinstances running on the same machine.However, I am not a fan of the runtime check and would rather have all packages be declaring
bitcoin-libinpeerDependencies. This way the enclosing package can specify whatever version ofbitcoin-libit wants andnpmwill inform user if there is an unmet dependency at install time rather than run time.I have a working example of
bitcore-librunning as a peerDependency at bitcore-docker-build which is also running testnet at bitcore.soapbubble.online/insight: