qt: Add sweep private key dialog#297
Open
kwsantiago wants to merge 2 commits intobitcoinknots:29.x-knotsfrom
Open
qt: Add sweep private key dialog#297kwsantiago wants to merge 2 commits intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 2 commits intobitcoinknots:29.x-knotsfrom
Conversation
kwsantiago
force-pushed
the
gui-sweep-privkey
branch
from
bd747f1 to
d5fc47f
Compare
Dialog that sweeps coins from WIF private key(s) into the active wallet by calling the sweepprivkeys RPC. Supports multiple keys (one per line) and an optional label. RPC runs on a background thread to avoid blocking the GUI. Private key text is scrubbed from memory on clear and close.
Add "Sweep private key..." action to the File menu, following the same pattern as Sign/Verify Message.
kwsantiago
force-pushed
the
gui-sweep-privkey
branch
from
d5fc47f to
804d4d1
Compare
Collaborator
|
Probably want a wallet chooser (when multiple wallets open) |
luke-jr
pushed a commit
that referenced
this pull request
Apr 14, 2026
Dialog that sweeps coins from WIF private key(s) into the active wallet by calling the sweepprivkeys RPC. Supports multiple keys (one per line) and an optional label. RPC runs on a background thread to avoid blocking the GUI. Private key text is scrubbed from memory on clear and close. Github-Pull: #297 Rebased-From: e01da56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sweepprivkeysRPC; supports multiple keys and optional labelRework of bitcoin-core/gui#650 per review feedback: import private key is a footgun, only sweep should be exposed in the GUI.