rpc: add segwit and taproot support to sweepprivkeys#296
Open
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
rpc: add segwit and taproot support to sweepprivkeys#296kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
sweepprivkeys only generated P2PKH and bare pubkey script needles, silently missing funds at P2WPKH, P2SH-P2WPKH, and P2TR addresses. Add all segwit output types to the UTXO scan, add the redeem script and taproot builder data needed for signing, and pass precomputed transaction data so Schnorr signatures work.
kwsantiago
force-pushed
the
fix-sweepprivkeys-segwit
branch
from
b3d54ef to
641c223
Compare
luke-jr
pushed a commit
that referenced
this pull request
Apr 13, 2026
sweepprivkeys only generated P2PKH and bare pubkey script needles, silently missing funds at P2WPKH, P2SH-P2WPKH, and P2TR addresses. Add all segwit output types to the UTXO scan, add the redeem script and taproot builder data needed for signing, and pass precomputed transaction data so Schnorr signatures work. Github-Pull: #296 Rebased-From: 641c223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sweepprivkeysonly scanned for P2PKH and bare pubkey outputs, silently missing funds at P2WPKH, P2SH-P2WPKH, and P2TR addressesPrecomputedTransactionDatato the signature creator so BIP341 Schnorr signing worksTest plan