blockstorage: fix unsigned underflow in GetBlockFileInfo bounds check#294
Open
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
blockstorage: fix unsigned underflow in GetBlockFileInfo bounds check#294kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
size()-1 wraps to SIZE_MAX when m_blockfile_info is empty, bypassing the bounds check and crashing via out_of_range from .at(n).
luke-jr
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetBlockFileInfochecksn > m_blockfile_info.size()-1which wraps to SIZE_MAX when the vector is empty.at(n)then throwsout_of_range, crashing the noden >= m_blockfile_info.size()insteadTest plan
blockmanager_tests): pass