kernel: Chainparams and headerssync updates from Core #34677#291
kernel: Chainparams and headerssync updates from Core #34677#291luke-jr wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
Conversation
Github-Pull: bitcoin#34677 Rebased-From: 5ca0c55
Github-Pull: bitcoin#34677 Rebased-From: 8eaf1d2
Github-Pull: bitcoin#34677 Rebased-From: cf261b0
Github-Pull: bitcoin#34677 Rebased-From: 58c2e23 (partial, mainnet only)
Github-Pull: bitcoin#34677 Rebased-From: 44538f8
There was a problem hiding this comment.
Independently verified all mainnet values against a fully synced Knots 29.3 node:
defaultAssumeValid (height 938343):
-
getblockhash 938343->00000000000000000000ccebd6d74d9194d8dcdc1d177c478e094bfad51ba5ac
nMinimumChainWork:
-
getblockheaderchainwork ->0000000000000000000000000000000000000001128750f82f4c366153a3a030
chainTxData (getchaintxstats 4096 @ 938343):
- nTime: 1772055173
- tx_count: 1315805869
- dTxRate: 5.40111006496122
assumeutxo (dumptxoutset rollback=935000):
- txoutset_hash:
e4b90ef9eae834f56c4b64d2d50143cee10ad87994c614d7d04125e2a6025050 - base_hash:
0000000000000000000147034958af1652b2b91bba607beacc5e72a56f0fb5ee - nchaintx: 1305397408
All values match the PR.
Retropex
left a comment
There was a problem hiding this comment.
All value match with my own node.
consensus.nMinimumChainWork -> 0000000000000000000000000000000000000001128750f82f4c366153a3a030
consensus.defaultAssumeValid -> 00000000000000000000ccebd6d74d9194d8dcdc1d177c478e094bfad51ba5ac
hash_serialized -> e4b90ef9eae834f56c4b64d2d50143cee10ad87994c614d7d04125e2a6025050
m_chain_tx_count -> 1305397408
blockhash -> 0000000000000000000147034958af1652b2b91bba607beacc5e72a56f0fb5ee
nTime -> 1772055173
tx_count -> 1315805869
dTxRate -> 5.40111006496122
Is there any reason not to apply them? |
Lack of review, at least :) |
|
Then I will verify all value for other networks and bring a review shortly |
Backport of bitcoin#34677 on Knots 29
When reviewing, please verify every change's correctness, not only that it works. These instructions may help
Also open to conceptual input on whether to apply the non-mainnet updates (currently the PR applies them and rolls them back)