init: Inform user of upcoming RDTS softfork and lack of enforcement by this software#289
Open
luke-jr wants to merge 7 commits intobitcoinknots:29.x-knotsfrom
Open
init: Inform user of upcoming RDTS softfork and lack of enforcement by this software#289luke-jr wants to merge 7 commits intobitcoinknots:29.x-knotsfrom
luke-jr wants to merge 7 commits intobitcoinknots:29.x-knotsfrom
Conversation
7cb0b65 to
e677c59
Compare
e677c59 to
5dd14d6
Compare
06d9282 to
71283f7
Compare
…to return true for ThreadSafeQuestion
71283f7 to
34c694b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #256 for a final pre-RDTS release
By default, informs the user of the upcoming softfork and warns that this version doesn't enforce it, but still runs (unless the GUI user clicks Abort).
If the user has already upgraded to RDTS previously, they are prompted to remove
consensusrules=rdtsfrom their config file(s), and the software does not start.If there's
consensusrulesset other than "rdts", simply error and fail to start. (I'll import this to #256 also)