Skip to content

qt: Collapsible sections for Mempool and Spam filtering tabs#281

Open
kwsantiago wants to merge 5 commits intobitcoinknots:29.x-knotsfrom
privkeyio:fix-gui-mempool-options-unwieldy
Open

qt: Collapsible sections for Mempool and Spam filtering tabs#281
kwsantiago wants to merge 5 commits intobitcoinknots:29.x-knotsfrom
privkeyio:fix-gui-mempool-options-unwieldy

Conversation

@kwsantiago
Copy link
Copy Markdown

Closes #71

Group options into collapsible sections and wrap Mempool tab in a scroll area.

@kwsantiago kwsantiago force-pushed the fix-gui-mempool-options-unwieldy branch from 24c4289 to 49a974f Compare March 7, 2026 02:15
@luke-jr
Copy link
Copy Markdown
Collaborator

luke-jr commented Mar 25, 2026

Checkboxes suggest the user is changing settings, and the wasted blank space for a collapsed section seems to defeat the point...

Maybe something looking like this: https://stackoverflow.com/questions/32476006/how-to-make-an-expandable-collapsable-section-widget-in-qt

@kwsantiago kwsantiago force-pushed the fix-gui-mempool-options-unwieldy branch from 49a974f to 5d2d9d1 Compare March 25, 2026 22:52
@luke-jr
Copy link
Copy Markdown
Collaborator

luke-jr commented Mar 30, 2026

Maybe open collapsed, but with Expand/Collapse All buttons?

eg https://ux.stackexchange.com/questions/138468/expand-all-collapse-all-expand-all-of-type-collapse-all-of-type

I also feel like the lines to the right of the section label should be clickable

@luke-jr
Copy link
Copy Markdown
Collaborator

luke-jr commented Mar 30, 2026

Thoughts on rearranging the furniture a bit at the same time? (In a separate commit)

7924862

Screenshot_20260330_145611-1 Screenshot_20260330_145303

@luke-jr luke-jr added this to the 29.3 (2nd) milestone Apr 3, 2026
Copy link
Copy Markdown
Collaborator

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can click the line now, but ONLY the line (quite thin) - probably need to detect clicks on the full height of the text.

There's also a custom cursor for the line, but not for the text. (Both should match whatever the OS normally uses for these kind of widgets)

Finally, because things are collapsed by default, the ModScrollArea starts with a smaller width, and upon expanding grows a horizontal scrollbar, which is ugly.

Comment thread src/qt/optionsdialog.cpp Outdated
@kwsantiago kwsantiago requested a review from luke-jr April 15, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GUI Mempool Options getting a bit unwieldy

2 participants