Add -mempoolreplacement=feerate option#275
Open
kwsantiago wants to merge 3 commits intobitcoinknots:29.x-knotsfrom
Open
Add -mempoolreplacement=feerate option#275kwsantiago wants to merge 3 commits intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 3 commits intobitcoinknots:29.x-knotsfrom
Conversation
kwsantiago
force-pushed
the
feature-rbf-feerate-mode
branch
from
d3e585a to
72ccdd5
Compare
luke-jr
reviewed
Mar 6, 2026
Add rbf_feerate_mode as a separate boolean flag rather than a standalone RBFPolicy enum value. This allows feerate-based RBF to combine with both OptIn and Always modes: -mempoolreplacement=feerate,optin (respect BIP125 signaling) -mempoolreplacement=feerate,-optin (full RBF + feerate rules) In feerate mode, Rule 3 (absolute fee check) is skipped and Rule 4 is relaxed to only require the replacement covers its own relay cost. Feerate diagram improvement is still required.
kwsantiago
force-pushed
the
feature-rbf-feerate-mode
branch
from
72ccdd5 to
c5f4c87
Compare
rleed
approved these changes
Mar 19, 2026
luke-jr
reviewed
Mar 23, 2026
luke-jr
reviewed
Mar 23, 2026
| case RBFPolicy::OptIn : ret.pushKV("rbf_policy", "optin"); break; | ||
| case RBFPolicy::Always : ret.pushKV("rbf_policy", "always"); break; | ||
| } | ||
| ret.pushKV("rbf_feerate", pool.m_opts.rbf_feerate_mode); |
Collaborator
There was a problem hiding this comment.
Not sure this is the way to go... Maybe rbf_policy should be deprecated and replaced with a config-compatible mempoolreplacement? Or maybe not... idk
Author
There was a problem hiding this comment.
Happy to rename or restructure this, do you have a preference between exposing it as a separate bool vs folding it into a combined mempoolreplacement string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds feerate mode: skip Rule 3 (absolute fee), keep Rule 4 (relay bandwidth), require feerate diagram improvement.
Closes #114