qt: Toggle banned peers visibility#274
Open
umop wants to merge 2 commits intobitcoinknots:29.x-knotsfrom
Open
Conversation
luke-jr
requested changes
Mar 5, 2026
luke-jr
requested changes
Mar 15, 2026
Collaborator
luke-jr
left a comment
There was a problem hiding this comment.
This change should be a single commit, with a subject like "GUI/Peers: Add button to hide/show ban table" and details after a blank line.
Adds a Hide/Show toggle button next to the "Banned peers" heading that allows users to collapse the ban table while keeping the heading visible. The state persists across sessions via QSettings.
9226e55 to
7c1a63c
Compare
luke-jr
reviewed
Mar 29, 2026
luke-jr
reviewed
Mar 29, 2026
luke-jr
requested changes
Mar 30, 2026
Collaborator
luke-jr
left a comment
There was a problem hiding this comment.
This is so close, but the Peers tab without any bans now has an extra padding at the bottom
…r spacing and implemented requested whitespace review fixes. Wrapped the ban heading and table in a container widget to control visibility and spacing as a unit. This ensures the ban section (including margins) only appears when banned peers exist, preventing excess bottom padding when the list is empty.
Author
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Closes #185
Adds a Hide / Show button on the banned peer list table which shows / hides banned table if visible. Default is to show. Also persists the state in
QSettings.Also cleaned up some indentation and closing tags in the
debugwindow.uiThere don't appear to be existing automated tests for individual Peers tab UI elements or visibility toggles. The existing Qt tests focus on RPC command parsing, wallet operations, and high-level integration testing rather than specific widget interactions.
Manually tested:
Showing:

Hidden:
