policy: reject tapscript spends exceeding input value#271
Open
kwsantiago wants to merge 4 commits intobitcoinknots:29.x-knotsfrom
Open
policy: reject tapscript spends exceeding input value#271kwsantiago wants to merge 4 commits intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 4 commits intobitcoinknots:29.x-knotsfrom
Conversation
luke-jr
requested changes
Mar 5, 2026
kwsantiago
force-pushed
the
policy-tapscript-dust-limit
branch
from
2d46bc7 to
c8ffdbf
Compare
kwsantiago
force-pushed
the
policy-tapscript-dust-limit
branch
3 times, most recently
from
c9ecfef to
de066f3
Compare
rleed
suggested changes
Mar 20, 2026
| self.sign_tapscript(tx) | ||
|
|
||
| result = self.nodes[0].testmempoolaccept([tx.serialize().hex()]) | ||
| assert_equal(result[0]["allowed"], False) |
There was a problem hiding this comment.
Difficult to follow. Where/how is the witness size expressed here? Why are two inputs needed to test this? Why is the fee treated as per-input, instead of calculating the actual cost to spend each (especially the dust) input? Why large margins and ~approximate values instead of testing exact boundaries?
luke-jr
requested changes
Mar 29, 2026
kwsantiago
force-pushed
the
policy-tapscript-dust-limit
branch
from
de066f3 to
3376dc7
Compare
luke-jr
reviewed
Mar 30, 2026
| bool permit_bare_multisig{DEFAULT_PERMIT_BAREMULTISIG}; | ||
| bool reject_parasites{DEFAULT_REJECT_PARASITES}; | ||
| bool reject_tokens{DEFAULT_REJECT_TOKENS}; | ||
| bool reject_net_negative_inputs{DEFAULT_REJECT_NET_NEGATIVE_INPUTS}; |
Collaborator
There was a problem hiding this comment.
Can we lose the underscores in the option name please? :)
| } | ||
| } | ||
|
|
||
| if (opts.reject_net_negative_inputs && whichType == TxoutType::WITNESS_V1_TAPROOT) { |
Collaborator
|
PR description ought to be updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-rejecttapscriptdustoption (default: true) that rejects mempool transactions containing tapscript script-path spends where the witness cost at the transaction's feerate exceeds the input value. Key-path spends are exempt, preserving UTXO cleanup capability.Includes GUI option and functional test coverage.
Closes #63
Closes #113