Add compile_tr() for Taptree-native policy compilation#270
Open
kwsantiago wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
Open
Add compile_tr() for Taptree-native policy compilation#270kwsantiago wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
Conversation
kwsantiago
force-pushed
the
compile-tr-native
branch
from
5fb98e1 to
34e837c
Compare
kwsantiago
force-pushed
the
compile-tr-native
branch
from
34e837c to
c142144
Compare
rleed
reviewed
Mar 20, 2026
| internal_keys.emplace_back(internal_keys.at(0)->Clone()); | ||
| } | ||
|
|
||
| key_exp_index += parser.m_keys.size(); |
There was a problem hiding this comment.
Where is key_exp_index used? (I've searched throughout the parser and I don't see it ever used.)
| } | ||
| ret.emplace_back(std::make_unique<TRDescriptor>(std::move(internal_keys.at(mp)), std::move(descs), depths)); | ||
| } | ||
| return ret; |
There was a problem hiding this comment.
Where can I find design material on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
compile_tr()which decomposes allOrandThreshbranches into separate TapTree leaves instead of usingOP_IF/OP_NOTIFwithin a single leaf. Each leaf is compiled to branch-free Tapscript and assembled into a Huffman-weighted TapTree.Also adds
HasBranchingOpcodes()tominiscript::Nodefor detectingOP_IF/OP_NOTIF-emitting fragments in compiled Tapscript.For reference: rust-bitcoin/rust-miniscript#906