Saturate CalculateExtraTxWeight and cap GUI datacarriercost to 1024#268
Open
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
Saturate CalculateExtraTxWeight and cap GUI datacarriercost to 1024#268kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
luke-jr
requested changes
Feb 25, 2026
kwsantiago
force-pushed
the
fix-extra-weight-overflow
branch
from
19f5713 to
df5e4a5
Compare
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mod_weightinCalculateExtraTxWeight to preventint32_t` overflow wrapping negativedatacarriercostmaximum fromMAX_BLOCK_SERIALIZED_SIZEto1024