Skip to content

BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message#1834

Closed
GarmashAlex wants to merge 1 commit into
bitcoin:masterfrom
GarmashAlex:hpp1
Closed

BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message#1834
GarmashAlex wants to merge 1 commit into
bitcoin:masterfrom
GarmashAlex:hpp1

Conversation

@GarmashAlex
Copy link
Copy Markdown
Contributor

@GarmashAlex GarmashAlex commented Apr 24, 2025

This commit updates the ProofOfReserves message in the Protocol Buffers specification
to use BIP44 coin type IDs from SLIP-0044 instead of network magic values.

The changes include:

  • Renaming the field from 'network_magic' to 'coin_type'
  • Updating the comments to reference the SLIP-0044 registry
  • Adding examples for Bitcoin mainnet (0x80000000) and Testnet (0x80000001)

@murchandamus murchandamus changed the title Replace network_magic with BIP44 coin_type in ProofOfReserves message BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message Apr 24, 2025
@murchandamus murchandamus added Proposed BIP modification PR by non-owner to update BIP content Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified labels Apr 24, 2025
@murchandamus
Copy link
Copy Markdown
Member

Pinging the author: @stevenroose

@jonatack
Copy link
Copy Markdown
Member

@stevenroose mind weighing in here, as BIP author?

@murchandamus
Copy link
Copy Markdown
Member

@stevenroose: If you have a minute, could you take a look at this?

@jonatack
Copy link
Copy Markdown
Member

This PR was opened one year ago today.

Friendly nudge to BIP author https://github.com/stevenroose if you can have a look here.

@murchandamus
Copy link
Copy Markdown
Member

I’ve pinged @stevenroose out of band. I propose that we close this PR as "no interest", if there is no review here in the next two weeks. I have also asked @stevenroose, whether BIP127 should be moved to either Closed or Complete, because it doesn’t seem that it is still being actively worked on.

@stevenroose
Copy link
Copy Markdown
Contributor

Yeah I don't think anyone is using the protocol buffers part from this BIP. I think I will make a PR to remove that part and then mark it as complete.

@stevenroose
Copy link
Copy Markdown
Contributor

Please close this in favor of #2168.

@jonatack
Copy link
Copy Markdown
Member

jonatack commented May 21, 2026

@GarmashAlex thanks for your proposal. Closing per the above feedback by the BIP author.

@jonatack jonatack closed this May 21, 2026
@murchandamus murchandamus removed the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants