Wallets: Add Trezor Safe 3, Safe 5, and Safe 7#4729
Open
zktex wants to merge 1 commit into
Open
Conversation
Adds the three current Trezor Safe family hardware wallets: Safe 3 (button interface, monochromatic OLED), Safe 5 (color touchscreen with haptic feedback), and Safe 7 (color touchscreen, encrypted Bluetooth, Qi2 charging). All three have open-source firmware, support SLIP-39 Multi-share Backup, and use EAL6+ certified Secure Elements; Safe 7 additionally pairs the auditable TROPIC01 chip.
Collaborator
|
Hi @zktex ! Quick question: are these new Safe listings referring to the regular Safe lineup, the Bitcoin-only editions, or both? The PR text felt generic, but the screenshots gave me the impression of the Bitcoin-only variants. |
Contributor
both |
Collaborator
|
LGTM |
Collaborator
|
@prusnak @zktex , I’m working with @crwatkins on the bitcoin.org wallet reviews. One remaining step on our side is a hands-on physical test of the Trezor Safe lineup. I can send the shipping details by email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the three current Trezor Safe family hardware wallets to the wallets list: Trezor Safe 3, Trezor Safe 5, and Trezor Safe 7.
This PR complements (and unblocks) #4664, which proposes removing the discontinued Trezor One and Model T. Per the discussion there with @crwatkins, the agreed sequencing is: list the current models first, then proceed with the removal of the older ones. I'm raising this PR to enable that next step. cc @devdavidejesus, @prusnak.
Closes trezor/trezor-firmware#6891.
Disclosure
I work with Trezor Company s.r.o. (a SatoshiLabs company, the maker of Trezor) on the firmware team.
What's added
For each of Safe 3, Safe 5, and Safe 7:
_wallets/trezorsafeN.md— wallet metadata, structured identically to the existingtrezormodelt.mdimg/wallet/trezorsafeN.png— 144×144 Trezor logo iconimg/screenshots/trezorsafeN.png— 250×350 device screenshotPlus three new entries in
_translations/en.yml(wallettrezorsafe3,wallettrezorsafe5,wallettrezorsafe7), placed adjacent to the existingwallettrezormodelt/wallettrezoronekeys.Codebase shared with the existing Model T listing
All three Safe models share the same
trezor-firmwarecodebase as the currently-listed Trezor Model T. The wallet-behavior surface (address generation, signing flow, multisig support, SLIP-39 backup, etc.) is therefore consistent with what bitcoin.org has already accepted via the Model T entry. The differences across the Safe lineup are physical (input method, display, connectivity, secure element) — they don't affect Bitcoin-handling logic.This is the reason the
featuresset and allcheckvalues matchtrezormodelt.mdexactly across all three new entries.Secure element
The main hardware difference from the Model T is the addition of a dedicated secure element. All three Safe models include the OPTIGA Trust M (V3) secure element, certified to Common Criteria EAL6+. Safe 7 additionally includes TROPIC01, an open, auditable secure element developed by Tropic Square (a SatoshiLabs company).
The secure element in Safe devices serves three roles: enforcing PIN verification in hardware (protecting against brute-force attempts on a stolen device), attesting device authenticity via a Trezor-signed certificate, and contributing an independent source of entropy during wallet seed generation. It does not perform transaction signing, and the signing logic remains fully open-source and reproducibly built, identically to the Model T.
The OPTIGA Trust M (V3) was chosen specifically because it is NDA-free, allowing public security research without restrictions. Further details: Secure Elements in Trezor Safe devices.
Descriptions
Descriptions in
_translations/en.ymlwere adapted from the official trezor.io product pages, with marketing language stripped to match the factual style of the existing wallet entries. All three are under the 320-character limit.Files changed
_wallets/trezorsafe3.md(new)_wallets/trezorsafe5.md(new)_wallets/trezorsafe7.md(new)img/wallet/trezorsafe3.png(new, 144×144, optipng -o7)img/wallet/trezorsafe5.png(new, 144×144, optipng -o7)img/wallet/trezorsafe7.png(new, 144×144, optipng -o7)img/screenshots/trezorsafe3.png(new, 250×350, optipng -o7)img/screenshots/trezorsafe5.png(new, 250×350, optipng -o7)img/screenshots/trezorsafe7.png(new, 250×350, optipng -o7)_translations/en.yml(modified — three new keys added adjacent to existing Trezor entries)