Need to force string when constructing error classes#252
Open
carsonreinke wants to merge 1 commit intobigcommerce:masterfrom
Open
Need to force string when constructing error classes#252carsonreinke wants to merge 1 commit intobigcommerce:masterfrom
carsonreinke wants to merge 1 commit intobigcommerce:masterfrom
Conversation
Author
|
Hello? @bookernath |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Some responses incorrectly throw error messages because there is a type mismatch on the arguments to the error constructors. Basically,
json_decodeon the response body is not guaranteed to return a string. We need to enforce the string.Writing test cases involved a lot of work unless a curl abstraction was built/used. Even mocking is extremely difficult here.
Tickets / Documentation
#223
Screenshots (if appropriate)
None
cc @jofomah