Skip to content

feat: remove MSstats post-processing step from quantms#701

Merged
ypriverol merged 12 commits intobigbio:devfrom
ypriverol:feat/remove-msstats-postprocessing
Apr 15, 2026
Merged

feat: remove MSstats post-processing step from quantms#701
ypriverol merged 12 commits intobigbio:devfrom
ypriverol:feat/remove-msstats-postprocessing

Conversation

@ypriverol
Copy link
Copy Markdown
Member

Summary

  • Removes MSSTATS_LFQ and MSSTATS_TMT modules and their R scripts (bin/msstats_plfq.R, bin/msstats_tmt.R, bin/msstats_utils.R) from the pipeline
  • Removes all MSstats-specific parameters from nextflow.config and nextflow_schema.json (skip_post_msstats, ref_condition, contrasts, msstats_* params)
  • Removes the MSstats publishDir block from conf/modules/shared.config
  • Keeps MSSTATS_CONVERTER (OpenMS) and DIANN_MSSTATS so quantms still produces msstats_in.csv as input for downstream MSstats analysis
  • Updates docs to clarify that users should run MSstats manually outside the pipeline

Motivation

MSstats post-processing is interactive and exploratory. Embedding it in the automated pipeline creates unnecessary complexity — users need to re-run with different contrasts or parameters. quantms should produce the MSstats-compatible input files and stop there, leaving statistical analysis to the user.

Closes #697 (if applicable)

Test plan

  • Run test_lfq profile: verify quant_tables/msstats_in.csv is still produced
  • Run test_tmt profile: verify quant_tables/out_msstats_in.csv is still produced
  • Run test_dia profile: verify msstats_in.csv is still produced
  • Verify msstats/ output directory is no longer created
  • Verify nf-schema validation passes

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 093ae8a4-bd34-4cc7-9ff8-db36a5191722

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 14, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the in-pipeline MSstats post-processing steps (R-based MSstats/MSstatsTMT execution) while keeping generation of MSstats-compatible input tables (*_msstats_in.csv) for downstream, user-run MSstats analysis.

Changes:

  • Removed MSSTATS_LFQ / MSSTATS_TMT modules and their invocation from LFQ/TMT/DIA workflows.
  • Removed MSstats post-processing parameters from nextflow.config and nextflow_schema.json, plus the dedicated msstats/ publishDir.
  • Updated output documentation and test configs to reflect that MSstats is no longer run inside the pipeline.

Reviewed changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
workflows/tmt.nf Drops MSSTATS_TMT step and stops emitting msstats_out.
workflows/lfq.nf Drops MSSTATS_LFQ step and stops emitting msstats_out.
workflows/dia.nf Drops MSSTATS_LFQ post-step and stops emitting msstats_out.
nextflow_schema.json Removes MSstats post-processing parameter group and schema reference.
nextflow.config Removes MSstats post-processing params defaults.
conf/modules/shared.config Removes msstats/ publishDir block for MSstats post-processing outputs.
conf/tests/test_localize.config Removes skip_post_msstats test param.
conf/tests/test_latest_dia.config Removes skip_post_msstats test param.
conf/tests/test_dia_dotd.config Removes skip_post_msstats test param.
conf/tests/test_dia.config Removes skip_post_msstats test param.
docs/output.md Updates output structure/docs to state MSstats is run externally.
modules/local/msstats/msstats_tmt/meta.yml Deleted MSstatsTMT module metadata.
modules/local/msstats/msstats_tmt/main.nf Deleted MSstatsTMT Nextflow process.
modules/local/msstats/msstats_lfq/meta.yml Deleted MSstats LFQ module metadata.
modules/local/msstats/msstats_lfq/main.nf Deleted MSstats LFQ Nextflow process.
bin/msstats_utils.R Deleted shared MSstats R helper script.
bin/msstats_tmt.R Deleted MSstatsTMT R runner script.
bin/msstats_plfq.R Deleted MSstats LFQ R runner script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ypriverol and others added 2 commits April 14, 2026 11:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix filename pattern: msstats_in.csv -> *_msstats_in.csv (prefix is workflow-dependent)
- Fix file type: TSV -> CSV (actual output is comma-separated)
- Rename misleading "MSstats-processed mzTab" heading to "MSstats post-processing (external)"
- Limit DDA pipelines to LFQ and ISO (DIA removed)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

ypriverol and others added 2 commits April 14, 2026 16:43
- Accept deletion of DIA files (dia.nf, test_dia*.config) merged via PR bigbio#702
- shared.config: remove MSSTATS_LFQ|MSSTATS_TMT publishDir block (our change)
  and FINAL_QUANTIFICATION|DIANN_MSSTATS from quant_tables pattern (from dev)
- nextflow_schema.json: remove both DIA-NN and statistical_post_processing
  $defs blocks and their allOf $refs (each PR removed one; merged = remove both)
- docs/output.md: remove DIA output structure sections (from dev) and
  MSstats-processed results entry (our change); keep improved MSstats
  description with correct filename pattern and CSV type

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ypriverol ypriverol merged commit d50ce6c into bigbio:dev Apr 15, 2026
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Move MSstats Out of quantms Into a Separate Downstream Workflow

3 participants