Merged
Conversation
- Add diann-2.3.2 to paths filter, change detection, and build matrix - Set 2.3.2 as the new :latest tag (replaces 2.2.0) - Add diann-*/** to PR path triggers for broader change detection Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoAdd DIA-NN 2.3.2 to CI/CD pipeline with latest tag
WalkthroughsDescription• Add DIA-NN 2.3.2 to CI/CD build matrix and path filters • Set 2.3.2 as new :latest tag, replacing 2.2.0 • Expand PR path triggers to include all diann subdirectories • Integrate version detection and conditional build logic Diagramflowchart LR
A["PR/Push Event"] -->|"diann-*/** paths"| B["Path Filter Detection"]
B -->|"diann_2_3_2 filter"| C["CHG_232 Environment Variable"]
C -->|"Build Matrix"| D["DIA-NN 2.3.2 Container"]
D -->|"ghcr.io/bigbio/diann:2.3.2"| E["Registry Push"]
D -->|"ghcr.io/bigbio/diann:latest"| E
F["DIA-NN 2.2.0"] -->|"ghcr.io/bigbio/diann:2.2.0"| E
File Changes1. .github/workflows/quantms-containers.yml
|
Code Review by Qodo
1. Workflow repushes latest tag
|
📝 WalkthroughWalkthroughThe GitHub Actions workflow for DIA-NN container builds was updated to expand path triggers to include all files under Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/quantms-containers.yml (1)
9-10: Optional: remove redundant DIA-NN path glob.Line 10 (
diann-*/**) already covers Line 9 (diann-*/Dockerfile), so keeping both is redundant. You can drop Line 9 to reduce maintenance noise.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/quantms-containers.yml around lines 9 - 10, Remove the redundant glob entry "diann-*/Dockerfile" since the broader pattern "diann-*/**" already includes that path; update the workflow file to keep only "diann-*/**" and remove the specific "diann-*/Dockerfile" line to avoid duplication.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/quantms-containers.yml:
- Around line 9-10: Remove the redundant glob entry "diann-*/Dockerfile" since
the broader pattern "diann-*/**" already includes that path; update the workflow
file to keep only "diann-*/**" and remove the specific "diann-*/Dockerfile" line
to avoid duplication.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1abb866c-eb50-425f-9e94-fc9b886a0e65
📒 Files selected for processing (1)
.github/workflows/quantms-containers.yml
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+67
to
+68
| {"context":"diann-2.3.2","tag":"ghcr.io/bigbio/diann:2.3.2","sif":"diann-sif:2.3.2","extra_tags":"ghcr.io/bigbio/diann:latest","chg":"CHG_232"}, | ||
| {"context":"diann-2.2.0","tag":"ghcr.io/bigbio/diann:2.2.0","sif":"diann-sif:2.2.0","extra_tags":"","chg":"CHG_220"}, |
There was a problem hiding this comment.
1. Workflow repushes latest tag 🐞 Bug ☼ Reliability
Because .github/workflows/** is treated as a change for diann_2_3_2 and DIA-NN 2.3.2 is tagged with ghcr.io/bigbio/diann:latest, a workflow-only change on main can rebuild and push :latest even when the diann-2.3.2 build context did not change.
Agent Prompt
### Issue description
Workflow-only changes (under `.github/workflows/**`) currently make `diann_2_3_2` appear “changed”, and since 2.3.2 carries the `ghcr.io/bigbio/diann:latest` extra tag, this can republish `:latest` even when the container context didn’t change.
### Issue Context
This makes `:latest` mutable due to CI config edits and can change image digests without any Dockerfile/context changes.
### Fix Focus Areas
- .github/workflows/quantms-containers.yml[41-52]
- .github/workflows/quantms-containers.yml[66-73]
- .github/workflows/quantms-containers.yml[82-94]
### Suggested change (one of)
1) Remove `.github/workflows/**` from the per-image `dorny/paths-filter` rules so only actual image-context changes trigger builds/pushes.
2) Add a separate `workflow_changed` filter and, when only workflow files changed, either:
- build without pushing (`push: false`), or
- exclude `extra_tags` (especially `:latest`) from the matrix for that run.
3) Gate publishing of `extra_tags` (e.g., `:latest`) to `release` events only.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add DIA-NN 2.3.2 to the container build and push CI/CD workflow.
diann-2.3.2to paths filter, change detection env vars, and build matrix:latesttag (was 2.2.0)diann-*/**path trigger for PRsThe Dockerfile at
diann-2.3.2/Dockerfilealready exists. This PR wires it into the CI so it gets built and pushed toghcr.io/bigbio/diann:2.3.2on merge/release.Needed by bigbio/quantmsdiann#32 (DDA support requires 2.3.2 container).
Summary by CodeRabbit
New Features
Chores