fix: clean every site's data on multisite uninstall

[galbus]

What & why

On a multisite network, deleting the plugin left all of its data in the database — including the beyondwords_api_key secret and beyondwords_project_id.

Uninstaller::cleanup_plugin_options() used is_multisite() ? delete_site_option() : delete_option(). But the plugin stores every option per-site via update_option() / register_setting() — there are no update_site_option() writes anywhere in src/. So on multisite the uninstall loop deleted wp_sitemeta rows that were never created and left every real option in wp_options / wp_N_options. Retaining an API secret the user believes was deleted is a data-hygiene/security concern, and the method's 0 return value silently masked the failure.

There is also a second layer: WordPress runs uninstall.php once, in the network's main-site context. So even a corrected delete_option() — plus the raw-SQL transient and post-meta cleanups, which operate on the per-site $wpdb->options / $wpdb->postmeta tables — would only ever clean the main site. Subsites were never iterated.

Changes

• cleanup_plugin_options() — delete_option() is now the unconditional primary path (runs on both single-site and multisite), with a defensive delete_site_option() sweep retained on multisite for any legacy network option.
• Uninstaller::run() (new) — iterates get_sites(['number' => 0]) + switch_to_blog(), cleans each site's options, transients and post-meta, then restore_current_blog(). uninstall.php now calls run(). The individual cleanup_* methods stay public with unchanged contracts.

Notes for reviewers

• number => 0 lifts get_sites()' default 100-site cap so no site is skipped on large networks.
• No phpcs:ignore or ruleset change was needed. switch_to_blog() is a WordPress-VIP-Go warning, but that ruleset already pins it to severity 3 — below the default reporting threshold of 5 — so phpcs stays clean.
• The same either/or pattern also exists in Updater::delete_deprecated_options() (src/core/class-updater.php). That is a separate finding and is intentionally out of scope here.

Testing

• npm run phpcs — clean (exit 0, full project scan).
• UninstallerTest (single-site): 50 tests, 366 assertions, all green.
• UninstallerTest under real multisite (WP_MULTISITE=1): the new run_cleans_every_site_on_multisite regression test passes — the API key, a transient and post-meta are removed on both the main site and a subsite (6 assertions across 2 sites). This test fails against the pre-fix code.

🤖 Generated with Claude Code

[github-actions]

✅ WordPress Plugin Check Report

✅ Status: Passed

📊 Report

All checks passed! No errors or warnings found.

---

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check