Player language

[nklhtv]

No description provided.

[gouravkhunger]

@nklhtv This is an initial automated PR review.

Soft score: Approve
Clean additive change; playerLanguage wired consistently across PlayerSettings, PlayerView, player.html, and docs. Only thing worth confirming: web SDK 0.4.7 actually exposes playerLanguage.

Full review

PR #19 Review — "Player language"

Author: nklhtv · Base: main · +8 −1, 4 files

Architectural map

Adds one new player setting playerLanguage (locale/language override for web player) plus SDK bump @beyondwords/player 0.4.6 → 0.4.7. Pure additive feature wiring through the existing settings pipeline.

Affected subsystems

• Public library API — PlayerSettings data class + PlayerView setter.
• WebView bridge — player.html prop mapping to embedded web player.
• Docs — compatibility table.

Dependency graph changes

Web player UMD dependency bumped 0.4.6→0.4.7 (loaded via proxy.beyondwords.io). Only external change. New setting assumes 0.4.7 supports playerLanguage — bump and feature land together, correct.

Public API changes

Additive, non-breaking:

• PlayerSettings.playerLanguage: String? = null
• PlayerView.setPlayerLanguage(String)

Both follow existing conventions exactly (nullable field, non-null setter, setProp("player.playerLanguage", …)). Field ordering consistent across Kotlin data class and JS mapping.

Risky files

None. Largest risk is the SDK version bump — behavior of unrelated features could shift 0.4.6→0.4.7, but that's standard dependency maintenance.

DB / auth / security / deployment / config

None. No DB, no auth, no secrets, no build/config changes.

Review priority order

1. player.html SDK bump — confirm 0.4.7 published on proxy and playerLanguage supported there.
2. PlayerView.kt / PlayerSettings.kt — trivial, pattern-consistent.
3. doc/compatibility.md — doc only.

Verdict

Clean, minimal, consistent with surrounding code. Only thing worth confirming: 0.4.7 web SDK actually exposes playerLanguage. No blockers.