Only set Resolved date when transitioning to inactive #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our RT instance we have multiple inactive states: resolved and closed. When work is completed on a ticket it is marked as resolved, and the Resolved date is updated accordingly. At a later stage the ticket is moved from resolved to closed, which prevents it being re-opened. Currently this change from resolved to closed changes the Resolved date again. With this change, the Resolved date is only set if transitioning from a non-inactive state to inactive (or the Resolved date isn't set).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our RT instance we have multiple inactive states: resolved and closed. When work is completed on a ticket it is marked as resolved, and the Resolved date is updated accordingly. At a later stage the ticket is moved from resolved to closed, which prevents it being re-opened.
Currently this change from resolved to closed changes the Resolved date again. With this change, the Resolved date is only set if transitioning from a non-inactive state to inactive (or the Resolved date isn't set).