Skip to content

fix(gmail-browser): include thread identity in fallback ids - #500

Merged
Milhouszhang merged 1 commit into
berabuddies:masterfrom
WaldenLee2005:fix/gmail-fallback-thread-id
Jul 7, 2026
Merged

fix(gmail-browser): include thread identity in fallback ids#500
Milhouszhang merged 1 commit into
berabuddies:masterfrom
WaldenLee2005:fix/gmail-fallback-thread-id

Conversation

@WaldenLee2005

Copy link
Copy Markdown
Collaborator

Summary

  • include Gmail thread identity in messageId-less fallback row ids so same-content rows in different threads no longer collide
  • bump the Gmail browser seen key version to 3 so existing seen stores rebaseline after the fallback id shape changes
  • add tests covering thread-aware fallback ids and the seen key version bump

Tests

  • cargo fmt -p puffer-cli
  • git diff --check
  • cargo test -p puffer-cli gmail_browser

Manual verification

  • configured gmail-browser against waikn31@gmail.com
  • confirmed normal live Gmail polling emitted both same-subject test messages
  • temporarily forced fallback ids locally and observed distinct fallback dedup keys:
  • removed the temporary debug edit before commit

Fixes #772.

@milhous milhous left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed locally. Scope is limited to gmail-browser fallback row identity and seen key migration; CI is green and local checks passed: cargo fmt -p puffer-cli --check, git diff --check, cargo test -p puffer-cli gmail_browser.

@Milhouszhang
Milhouszhang merged commit 8f59a40 into berabuddies:master Jul 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants