Skip to content

fix(desktop): add duplicate-risk retry affordance - #499

Merged
Milhouszhang merged 2 commits into
berabuddies:masterfrom
WaldenLee2005:fix/issue-776-ack-retry-ui
Jul 7, 2026
Merged

fix(desktop): add duplicate-risk retry affordance#499
Milhouszhang merged 2 commits into
berabuddies:masterfrom
WaldenLee2005:fix/issue-776-ack-retry-ui

Conversation

@WaldenLee2005

Copy link
Copy Markdown
Collaborator

Summary

Fixes agentenv/monorepo#776 by adding an explicit duplicate-risk acknowledgement path for uncertain outbound approval cards.

When an outbound action is in uncertain, the desktop card now:

  • shows a distinct Confirm no duplicate & retry control alongside Cancel
  • gates retry behind a confirmation dialog explaining the unknown-send/duplicate risk
  • fetches the fresh action version with outbound_action_status
  • re-executes with duplicate_risk_ack: true
  • preserves existing sentinel handling for version mismatch, terminal actions, expiry, and duplicate-risk rejection

Nuance: the ack-retry affordance replaces the normal approve button only while the card is in uncertain, rather than adding a third button next to a disabled approve. This keeps the action explicit and visually distinct while avoiding a dead primary control.

Tests

  • npm --prefix apps/puffer-desktop exec vitest run src/lib/api/desktop.workflow-daemon.test.ts
  • npm --prefix apps/puffer-desktop exec vitest run src/lib/screens/agent/connectorDraftStatus.test.ts
  • npm --prefix apps/puffer-desktop run check
  • PUFFER_DESKTOP_TEST_PORT=1441 PUFFER_DESKTOP_USE_SYSTEM_CHROME=1 npm --prefix apps/puffer-desktop run test:desktop -- tests/outbound-gate-matrix.spec.ts

@WaldenLee2005 WaldenLee2005 self-assigned this Jul 6, 2026
@Milhouszhang
Milhouszhang merged commit 1886149 into berabuddies:master Jul 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants