fix(desktop): add duplicate-risk retry affordance - #499
Merged
Milhouszhang merged 2 commits intoJul 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes agentenv/monorepo#776 by adding an explicit duplicate-risk acknowledgement path for uncertain outbound approval cards.
When an outbound action is in
uncertain, the desktop card now:Confirm no duplicate & retrycontrol alongside Canceloutbound_action_statusduplicate_risk_ack: trueNuance: the ack-retry affordance replaces the normal approve button only while the card is in
uncertain, rather than adding a third button next to a disabled approve. This keeps the action explicit and visually distinct while avoiding a dead primary control.Tests
npm --prefix apps/puffer-desktop exec vitest run src/lib/api/desktop.workflow-daemon.test.tsnpm --prefix apps/puffer-desktop exec vitest run src/lib/screens/agent/connectorDraftStatus.test.tsnpm --prefix apps/puffer-desktop run checkPUFFER_DESKTOP_TEST_PORT=1441 PUFFER_DESKTOP_USE_SYSTEM_CHROME=1 npm --prefix apps/puffer-desktop run test:desktop -- tests/outbound-gate-matrix.spec.ts