Properly split the domain name to support more than two levels of domain component (dc)#6
Open
mistaka0s wants to merge 1 commit into
Open
Properly split the domain name to support more than two levels of domain component (dc)#6mistaka0s wants to merge 1 commit into
mistaka0s wants to merge 1 commit into
Conversation
…ain component (dc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code only splits the last two domain levels in the variable openldap_server_domain_name.
So if you have: subdomain.example.com, the domain component string will be: dc=subdomain, dc=example
The fix will split the whole openldap_server_domain_name and have a domain component for each level.
Real life example will be in countries which use a second level domain. eg ecetera.com.au will now be properly parsed as dc=ecetera,dc=com,dc=au