refactor: remove obsolete CPU and menu bar overrides - #627
Merged
Conversation
benletchford
marked this pull request as ready for review
August 14, 2026 11:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cpu-mhzCLI option and its GUI-only instruction-cap machinery--show-menu-barandSYSTEMLESS_SHOW_MENU_BARWhy
The CPU override duplicated the canonical machine profile while only affecting one frontend pacing path. Menu presentation was similarly expressed as a global boolean, which made kiosk behavior the library default and conflated frontend chrome policy with guest
MBarHeightandDrawMenuBarstate.The new policy keeps the emulation core guest-controlled by default. Frontends can request an initial kiosk presentation that releases when the guest explicitly draws or reveals its menu bar, or force the framebuffer menu bar hidden when menus are presented natively.
Validation
cargo fmt --all --checkcargo test --lib(2,955 passed; 3 ignored)cargo test --bin systemless(51 passed)cargo check --no-default-features --libCloses #625