fix: decode indexed PixMaps in PICT BitsRect opcodes - #617
Closed
benletchford wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by #607, which preserves the general unpacked BitsRect path and now also includes bounded opcode scanning and stream-synchronization coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BitsRectandBitsRgnopcodesRoot cause
BitsRectandBitsRgnwere always parsed as one-bit BitMaps. PICT v2 also permits an indexed PixMap when the high bit ofrowBytesis set, so the decoder skipped the PixMap header and color table and then interpreted image bytes as later opcodes.Validation
cargo fmt --checkcargo test --lib trap::pict::tests(31 passed)BitsRectCloses #606