fix: honor small classic application partitions - #605
Draft
benletchford wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604.
Root cause
The classic application loader ignored valid
SIZEpartitions when the minimum partition was at or below 2 MiB. It also positioned the A5 world using the minimum partition even though a normal launch first attempts the preferred partition. Spectre Supreme consequently received its A5 world near the loaded image and reported that it lacked the memory declared by its ownSIZEresource.Change
Qualification
The checksum-pinned Spectre Supreme demo reaches its menu, vehicle selection, and live single-player arena. Numeric-keypad movement visibly changes the vehicle position, and firing with Space reduces ammunition from 40 to 38 while play continues.
Validation
cargo fmt --checkcargo test --lib: 2,950 passed, 3 ignoredcargo check --no-default-features: passed